Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

webpack - fix fonts matching multiple webpack rules #12284

Merged
merged 1 commit into from
Dec 19, 2017

Conversation

petemill
Copy link
Member

Fixes fonts and icons not loading correctly due to new rules introduced in #12225
Fix #12280

Submitter Checklist:

  • Submitted a ticket for my issue if one did not already exist.
  • Used Github auto-closing keywords in the commit message.
  • Added/updated tests for this change (for new code or code which already has tests).
  • Ran git rebase -i to squash commits (if needed).
  • Tagged reviewers and labelled the pull request as needed.

Test Plan:
STR on #12280

Reviewer Checklist:

Tests

  • Adequate test coverage exists to prevent regressions
  • Tests should be independent and work correctly when run individually or as a suite ref
  • New files have MPL2 license header

@petemill petemill added this to the 0.22.x (Nightly Channel) milestone Dec 14, 2017
@petemill petemill self-assigned this Dec 14, 2017
@codecov-io
Copy link

codecov-io commented Dec 14, 2017

Codecov Report

Merging #12284 into master will decrease coverage by 0.03%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master   #12284      +/-   ##
==========================================
- Coverage   55.28%   55.25%   -0.04%     
==========================================
  Files         276      276              
  Lines       26744    26744              
  Branches     4311     4311              
==========================================
- Hits        14786    14777       -9     
- Misses      11958    11967       +9
Flag Coverage Δ
#unittest 55.25% <ø> (-0.04%) ⬇️
Impacted Files Coverage Δ
js/stores/appStoreRenderer.js 91.17% <0%> (-8.83%) ⬇️
app/renderer/components/reduxComponent.js 84.37% <0%> (-6.25%) ⬇️
js/stores/windowStore.js 26.71% <0%> (-0.3%) ⬇️

Fixes fonts and icons not loading correctly due to new rules introduced in brave#12225
Fix brave#12280
Copy link
Contributor

@cezaraugusto cezaraugusto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

errors are gone but I'm not into the new design spec. Is this UI accurate? if so lgtm.

screen shot 2017-12-19 at 12 03 00 am

@petemill
Copy link
Member Author

petemill commented Dec 19, 2017 via email

@cezaraugusto cezaraugusto merged commit ddac987 into brave:master Dec 19, 2017
@bbondy bbondy modified the milestones: 0.22.x (Developer Channel), 0.23.x (Nightly Channel) Feb 25, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants