Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Add property for global non-ledger notificationBar #12330

Merged
merged 1 commit into from
Dec 22, 2017

Conversation

diracdeltas
Copy link
Member

@diracdeltas diracdeltas commented Dec 19, 2017

Fix #12216

Test Plan:

  1. check that there are no new notificationBar test failures in travis
  2. go to about:preferences
  3. change PDF.JS setting. the 'Restart now?' notification should appear above the tabs bar.

Submitter Checklist:

  • Submitted a ticket for my issue if one did not already exist.
  • Used Github auto-closing keywords in the commit message.
  • Added/updated tests for this change (for new code or code which already has tests).
  • Ran git rebase -i to squash commits (if needed).
  • Tagged reviewers and labelled the pull request as needed.

Test Plan:

Reviewer Checklist:

Tests

  • Adequate test coverage exists to prevent regressions
  • Tests should be independent and work correctly when run individually or as a suite ref
  • New files have MPL2 license header

Fix #12216

Test Plan:
1. check that there are no new notificationBar test failures in travis
2. go to about:preferences
3. change PDF.JS setting. the 'Restart now?' notification should appear above the tabs bar.
@diracdeltas diracdeltas added this to the 0.20.x (Beta Channel) milestone Dec 19, 2017
@diracdeltas diracdeltas self-assigned this Dec 19, 2017
@codecov-io
Copy link

codecov-io commented Dec 19, 2017

Codecov Report

Merging #12330 into master will increase coverage by 0.23%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master   #12330      +/-   ##
==========================================
+ Coverage   55.29%   55.52%   +0.23%     
==========================================
  Files         276      276              
  Lines       26740    27235     +495     
  Branches     4310     4538     +228     
==========================================
+ Hits        14786    15123     +337     
- Misses      11954    12112     +158
Flag Coverage Δ
#unittest 55.52% <100%> (+0.23%) ⬆️
Impacted Files Coverage Δ
app/browser/windows.js 37.53% <ø> (ø) ⬆️
app/browser/api/ledgerNotifications.js 74.56% <100%> (ø) ⬆️
app/common/state/notificationBarState.js 100% <100%> (ø) ⬆️
app/renderer/components/common/switchControl.js 82.66% <0%> (-2.7%) ⬇️
js/constants/windowConstants.js 100% <0%> (ø) ⬆️
app/renderer/components/styles/global.js 100% <0%> (ø) ⬆️
js/actions/windowActions.js 5.02% <0%> (+0.16%) ⬆️
app/renderer/components/common/messageBox.js 88.34% <0%> (+0.59%) ⬆️
js/about/preferences.js 45.98% <0%> (+0.86%) ⬆️
...erer/components/preferences/payment/ledgerTable.js 89.51% <0%> (+1.76%) ⬆️
... and 6 more

Copy link
Contributor

@cezaraugusto cezaraugusto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

++

@cezaraugusto cezaraugusto merged commit 8dc6b12 into master Dec 22, 2017
@cezaraugusto cezaraugusto deleted the fix/restart-bar branch December 22, 2017 00:34
cezaraugusto added a commit that referenced this pull request Dec 22, 2017
Add property for global non-ledger notificationBar
cezaraugusto added a commit that referenced this pull request Dec 22, 2017
Add property for global non-ledger notificationBar
@cezaraugusto
Copy link
Contributor

master 8dc6b12
0.21.x 9ccd969
0.20.x 09728fe

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants