This repository has been archived by the owner on Dec 11, 2019. It is now read-only.
clear old pinned items stored in wrong position #12968
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #12968 +/- ##
==========================================
+ Coverage 56.14% 56.14% +<.01%
==========================================
Files 279 279
Lines 27326 27331 +5
Branches 4443 4444 +1
==========================================
+ Hits 15341 15346 +5
Misses 11985 11985
|
petemill
reviewed
Feb 2, 2018
| if (data.about.newtab.pinnedTopSites) { | ||
| // Empty array is currently set to include default pinned sites | ||
| // which we avoid given the user already have a profile | ||
| data.about.newtab.pinnedTopSites = [null] |
There was a problem hiding this comment.
How come we're setting this to an array with one null item inside and not an empty array with [] @cezaraugusto ?
There was a problem hiding this comment.
see https://github.com/brave/browser-laptop/blob/master/app/common/state/aboutNewTabState.js#L41 an empty array would populate top sites with default pinned site, which should only happen on an empty profile
petemill
approved these changes
Feb 7, 2018
petemill
added a commit
that referenced
this pull request
Feb 7, 2018
clear old pinned items stored in wrong position
petemill
added a commit
that referenced
this pull request
Feb 7, 2018
clear old pinned items stored in wrong position
petemill
added a commit
that referenced
this pull request
Feb 7, 2018
clear old pinned items stored in wrong position
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #12941
TL;DR: The bug is caused because pinned top sites were stored in a wrong position -- instead of own index they were pushed to the first index, causing duplicates. Since duplicated keys are hidden you ended up having only one tile.
The fix cleans pinned top sites from the previous version.
Test Plan: