Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Adds promo code to the state #13083

Merged
merged 1 commit into from
Feb 9, 2018
Merged

Conversation

NejcZdovc
Copy link
Contributor

@NejcZdovc NejcZdovc commented Feb 9, 2018

Resolves #13082

Submitter Checklist:

  • Submitted a ticket for my issue if one did not already exist.
  • Used Github auto-closing keywords in the commit message.
  • Added/updated tests for this change (for new code or code which already has tests).
  • Ran git rebase -i to squash commits (if needed).
  • Tagged reviewers and labelled the pull request as needed.
  • Request a security/privacy review as needed. (Ask a Brave employee to help if you cannot access this document.)

Test Plan:

make sure that when doing update check we are sending ref with it

Reviewer Checklist:

  • Request a security/privacy review as needed if one was not already requested.

Tests

  • Adequate test coverage exists to prevent regressions
  • Tests should be independent and work correctly when run individually or as a suite ref
  • New files have MPL2 license header

@NejcZdovc NejcZdovc added this to the 0.20.x Hotfix 2 (Referral Promotion) milestone Feb 9, 2018
@NejcZdovc NejcZdovc self-assigned this Feb 9, 2018
@NejcZdovc NejcZdovc requested a review from srirambv February 9, 2018 16:50
@NejcZdovc NejcZdovc force-pushed the hotfix/#13082-ref branch 2 times, most recently from d6d825b to a0ec1f4 Compare February 9, 2018 20:17
@codecov-io
Copy link

codecov-io commented Feb 9, 2018

Codecov Report

Merging #13083 into master will increase coverage by 0.02%.
The diff coverage is 80%.

@@            Coverage Diff             @@
##           master   #13083      +/-   ##
==========================================
+ Coverage   56.29%   56.31%   +0.02%     
==========================================
  Files         280      280              
  Lines       27568    27581      +13     
  Branches     4494     4497       +3     
==========================================
+ Hits        15520    15533      +13     
  Misses      12048    12048
Flag Coverage Δ
#unittest 56.31% <80%> (+0.02%) ⬆️
Impacted Files Coverage Δ
js/actions/appActions.js 19.78% <ø> (ø) ⬆️
app/updater.js 26.31% <0%> (ø) ⬆️
app/browser/api/ledger.js 57.09% <100%> (+0.24%) ⬆️
app/browser/reducers/ledgerReducer.js 46.92% <50%> (+0.13%) ⬆️

bsclifton
bsclifton previously approved these changes Feb 9, 2018
Copy link
Member

@bsclifton bsclifton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

++ LGTM 😄

@NejcZdovc NejcZdovc force-pushed the hotfix/#13082-ref branch 2 times, most recently from 7742e4f to f95b256 Compare February 9, 2018 20:23
Resolves brave#13082

Auditors:

Test Plan:
Copy link
Member

@bsclifton bsclifton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

++

@NejcZdovc NejcZdovc merged commit 46a3b05 into brave:master Feb 9, 2018
NejcZdovc added a commit that referenced this pull request Feb 9, 2018
NejcZdovc added a commit that referenced this pull request Feb 9, 2018
@NejcZdovc
Copy link
Contributor Author

NejcZdovc commented Feb 9, 2018

master 46a3b05
0.22 034ced2
0.21 efe6957
0.20 cc363a9

NejcZdovc added a commit that referenced this pull request Feb 9, 2018
@diracdeltas
Copy link
Member

lgtm

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants