This repository has been archived by the owner on Dec 11, 2019. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 973
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NejcZdovc
force-pushed
the
hotfix/#13082-ref
branch
2 times, most recently
from
February 9, 2018 20:17
d6d825b
to
a0ec1f4
Compare
Codecov Report
@@ Coverage Diff @@
## master #13083 +/- ##
==========================================
+ Coverage 56.29% 56.31% +0.02%
==========================================
Files 280 280
Lines 27568 27581 +13
Branches 4494 4497 +3
==========================================
+ Hits 15520 15533 +13
Misses 12048 12048
|
bsclifton
previously approved these changes
Feb 9, 2018
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
++ LGTM 😄
NejcZdovc
force-pushed
the
hotfix/#13082-ref
branch
2 times, most recently
from
February 9, 2018 20:23
7742e4f
to
f95b256
Compare
Resolves brave#13082 Auditors: Test Plan:
NejcZdovc
force-pushed
the
hotfix/#13082-ref
branch
from
February 9, 2018 20:26
f95b256
to
d78cb6d
Compare
bsclifton
approved these changes
Feb 9, 2018
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
++
lgtm |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #13082
Submitter Checklist:
git rebase -i
to squash commits (if needed).Test Plan:
make sure that when doing update check we are sending ref with it
Reviewer Checklist:
Tests