This repository has been archived by the owner on Dec 11, 2019. It is now read-only.
Adds confirmation dialog upon clicking the trash icon in the ledger table. #13128
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@bsclifton I hope I got the PR title right this time ;) I hope that the dialogue provided in this PR is appropriate, should a change in language work better, let me know and I can update those locales. cc: @NejcZdovc @luixxiul |
|
@bradleyrichter how does the wording for this look?
|
Codecov Report
@@ Coverage Diff @@
## master #13128 +/- ##
==========================================
- Coverage 56.18% 56.14% -0.04%
==========================================
Files 279 279
Lines 27873 27876 +3
Branches 4560 4561 +1
==========================================
- Hits 15660 15651 -9
- Misses 12213 12225 +12
|
|
Will review of this up to @NejcZdovc 😄 There are some planned changes for this UI (we may want to make those first): #13056 |
NejcZdovc
reviewed
Feb 19, 2018
| @@ -24,6 +24,7 @@ autoplay=Autoplay Media | |||
| autoSuggestSites=auto-incluir | |||
| backupLedger=Copia de seguridad de tu cartera | |||
| balanceRecovered=Se ha recuperado un total de {{balance}} y se han transferido a tu cartera Brave. | |||
| banSiteConfirmation=¿Seguro que quieres eliminar este sitio? | |||
There was a problem hiding this comment.
Please remove this line. We are doing translations via Transifex https://github.com/brave/browser-laptop/blob/master/docs/translations.md
There was a problem hiding this comment.
@NejcZdovc apologies there, i've removed this line.
|
@ryanml can you please squash commits? Then we are good to go |
Possibly fixes #13127 Auditors: @NejcZdovc
Only the installing user, or any admin-user should be able to update the app. Fix #13130
Test Plan: npm run test -- --grep="ledger export utilities test"
Resolves #12688 Auditors: Test Plan:
…'wasted' time, total time and number of invocations This option counts: - all time that is spent in all component mergeProps functions that results in no properties actually changing (and therefore no render), every 1 second. This is an important metric to improve since this is blocking the renderer window UI thread, and the time is likely spent re-computing functions even though the state input to those functions has not changed. - total time for each Component-type spent in mergeProps, output every 10 seconds - number of invocations for each Component-type mergeProps, output every 10 seconds
Resolves #13021 Auditors: Test Plan:
…s more instantly A buffer window is created at startup, and any time a previous buffer window is detached in order to be utilized as a real window. This type of window is not shown and has no tabs (pinned or non-pinned) until it is shown. State is not persisted for Buffer Windows until they are utilized as real windows. A new command-line flag is introduced: '--debug-window-events' which shows logging around Buffer Window creation and utilization, as well as all other window events. No additional logging should be present without this flag. Fix #12437
Needed for brave/https-everywhere-builder#3 Note that this is a breaking change from HTTPS Everywhere 5.x's ruleset format.
Resolves #11238 Auditors: Test Plan:
|
See #13182 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes Issue #11164
Submitter Checklist:
git rebase -ito squash commits (if needed).Test Plan:
Reviewer Checklist:
Tests
Two translations added under the name: banSiteConfirmation. Mechanism for creating the confirmation dialogue mimics that shown in the syncTable component. Ref: here