This repository has been archived by the owner on Dec 11, 2019. It is now read-only.
Show intermediate errors in pinned tabs #13610
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #8639
If loading a pinned tab errors, the error is not shown in the pinned tab, but is shown in a new tab which does not show the url which errors. The pinned tab then shows a non-branded error page. This can be a confusing UX as we've seen here, as it's not clear where the error tab has come from.
Submitter Checklist:
git rebase -i
to squash commits (if needed).Test Plan:
On #8639 but also:
Steps to Reproduce
Actual result:
2 additional tabs are created with errors that do not specify which url or tab caused those errors.
Pinned ebay.com tab shows unbranded error.
Expected result:
Error is shown in pinned ebay tab, and upon resolving of the error (clearing cookies), and restarting, ebay continues to load in a pinned tab.
- verify that when the error is resolved, the pinned tab has remembered which url it is supposed to load
Reviewer Checklist:
Tests