Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Fixes Audio indicator if tab muted and video stops playing #13873

Merged
merged 1 commit into from
May 7, 2018

Conversation

TheKinshu
Copy link

@TheKinshu TheKinshu commented Apr 20, 2018

Fix #12569

I have added something to check if the audio in the tab is muted or not within the audioState file. I have also made added a test for the new changes.

Submitter Checklist:

  • Submitted a ticket for my issue if one did not already exist.
  • Used Github auto-closing keywords in the commit message.
  • Added/updated tests for this change (for new code or code which already has tests).
  • Ran git rebase -i to squash commits (if needed).
  • Tagged reviewers and labelled the pull request as needed.
  • Request a security/privacy review as needed. (Ask a Brave employee to help if you cannot access this document.)

Test Plan:

Reviewer Checklist:

  • Request a security/privacy review as needed if one was not already requested.

Tests

  • Adequate test coverage exists to prevent regressions
  • Tests should be independent and work correctly when run individually or as a suite ref
  • New files have MPL2 license header

@ryanml
Copy link
Contributor

ryanml commented Apr 20, 2018

@TheKinshu thank you for your contribution :D We'll see that it gets reviewed.

I left some feedback regarding the code formatting, as it is causing the linter fail.

A tip is to run npm run lint before you push your changes, it will let you know what needs to be changed and how. Let me know if you have any questions!

@ryanml ryanml requested review from petemill and srirambv April 20, 2018 04:49
@NejcZdovc NejcZdovc requested a review from cezaraugusto April 20, 2018 05:05
@TheKinshu
Copy link
Author

@ryanml Thanks for the reply :). I'll fix the linter error right away.

@bsclifton bsclifton added this to the Completed work milestone Apr 26, 2018
@bsclifton bsclifton modified the milestones: Completed work, 0.24.x (Nightly Channel) May 7, 2018
@bsclifton bsclifton self-requested a review May 7, 2018 17:28
Copy link
Member

@bsclifton bsclifton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great fix- thanks for including the test too 😄 👍

@bsclifton bsclifton merged commit d8438b3 into brave:master May 7, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants