Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Show history on long click over back button #2435

Closed
wants to merge 1 commit into from
Closed

Show history on long click over back button #2435

wants to merge 1 commit into from

Conversation

bsclifton
Copy link
Member

  • Submitted a ticket for my issue if one did not already exist.
  • Used Github auto-closing keywords in the commit message.
  • Ran git rebase -i to squash commits if needed.

Shows context menu when click-and-hold over back button. Works great, except it'll continue to propagate the click (opening this PR while I figure that part out- help is appreciated)

Will fix #1622 (although, it doesn't match the wireframe yet)

Shows context menu when click-and-hold over back button. Works great, although, it doesn't match the wireframe yet.
Definitely would like feedback on how this could be cleaner :)

cc: @bbondy @bridiver

Next step would be to start making this match the wireframe (favicon, title, different styles than regular context menu)

Will fix #1622
@bbondy
Copy link
Member

bbondy commented Jul 12, 2016

Looking good but still needs some things before we can merge it in:

  • We should show titles instead of URLs, it would be ideal to get it from electron if available there, but if not you can use the app state's sites.
  • Pls also add favicons to the left of the items.
  • The amount of time you have to hold is too long currently. See chrome/firefox for a comparison.
  • Pls also do the same type of thing for the forward button.

@bbondy bbondy added this to the 0.11.2dev milestone Jul 12, 2016
@bsclifton
Copy link
Member Author

Awesome feedback- I'll be doing my best to get it matching the mockup provided by @bradleyrichter

Would it make sense to encapsulate the back/foward buttons as a React component? It could help keep main.js clean and would encapsulate the event handlers too

@bbondy
Copy link
Member

bbondy commented Jul 12, 2016

Yep, in general, the more smaller react components the better.

@bsclifton
Copy link
Member Author

Going to close this PR for the moment while I implement the feedback. Thanks, folks 😄

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Holding on back button should show the list of previous pages to choose
2 participants