Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Remove extra separator menu item (doesn't show on Mac) #3673

Merged
merged 1 commit into from
Sep 3, 2016
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 11 additions & 4 deletions app/browser/menu.js
Original file line number Diff line number Diff line change
Expand Up @@ -364,7 +364,7 @@ const createHistorySubmenu = (CommonMenu) => {
}

const createBookmarksSubmenu = (CommonMenu) => {
return [
let submenu = [
{
label: locale.translation('bookmarkPage'),
type: 'checkbox',
Expand All @@ -386,9 +386,16 @@ const createBookmarksSubmenu = (CommonMenu) => {
CommonMenu.bookmarksManagerMenuItem(),
CommonMenu.bookmarksToolbarMenuItem(),
CommonMenu.separatorMenuItem,
CommonMenu.importBookmarksMenuItem(),
CommonMenu.separatorMenuItem
].concat(menuUtil.createBookmarkMenuItems())
CommonMenu.importBookmarksMenuItem()
]

const bookmarks = menuUtil.createBookmarkMenuItems()
if (bookmarks.length > 0) {
submenu.push(CommonMenu.separatorMenuItem)
submenu = submenu.concat(bookmarks)
}

return submenu
}

const createWindowSubmenu = (CommonMenu) => {
Expand Down
6 changes: 5 additions & 1 deletion js/contextMenus.js
Original file line number Diff line number Diff line change
Expand Up @@ -870,7 +870,11 @@ function mainTemplateInit (nodeProps, frame) {
label: locale.translation('redo'),
accelerator: 'Shift+CmdOrCtrl+Z',
role: 'redo'
}, CommonMenu.separatorMenuItem, ...editableItems, CommonMenu.separatorMenuItem)
}, CommonMenu.separatorMenuItem)

if (editableItems.length > 0) {
template.push(...editableItems, CommonMenu.separatorMenuItem)
}
} else if (isTextSelected) {
if (isDarwin) {
template.push(showDefinitionMenuItem(nodeProps.selectionText),
Expand Down