-
Notifications
You must be signed in to change notification settings - Fork 972
Add multiple selection for about:history #4607
Conversation
Great job, @darkdh 😄 One concern I have is for the selected items. @bradleyrichter, what do you think about the colors? The dark orange is multi-selected, the light orange is hovered. If you hover over a multi-select, it looks like this: It feels good- but the concern I had is readability. We may choose to change the font color (white or lighter color) to make selected items easier to read |
} | ||
|
||
module.exports.isWindows = () => { | ||
return os.platform() === 'win32' | ||
return os.platform() === 'win32' || | ||
navigator.platform === 'Win32' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks for adding these checks in 😄
Reviewed the code in detail, changes look great 👍 |
Enhanced readability as |
Could you also select Shift + click for range selections? |
Working on it |
++ looks great 😄 Thanks for spending the time to make the tests too |
fix #3949 Auditors: @bsclifton, @bbondy Test Plan: For click behavior 1. First click should select a entry 2. All the following entries should be selectd with cmd/ctrl + click 3. Another click without cmd/ctrl should cancel selection 1. Click one entry 2. Shift + click another entry in the same table 3. The entry between these two will also be selected 1. Click one entry as start point 2. command/control click other entries between start point and end point in next step 3. Shift + click an entry as end point 4. The entry between start and end point should be selected Note that range select are not allow across tables For multi selector 1. Open about:history 2. Multi-select entries 3. Test "Open Links in New Tabs" 4. Test "Open Links in New Private Tabs" 5. Test "Open Links in New Session Tabs" 6. Test "Delete History Entries"
965adb0
to
5b01e0d
Compare
git rebase -i
to squash commits (if needed).fix #3949
Auditors: @bsclifton, @bbondy
Test Plan:
For click behavior
For shift click behavior
For shift click + cmd/control click
For multi selector