do not show coinbase for unsupported countries #4615
Conversation
jkup
added
the
design
jkup
force-pushed
the
bitcoin-without-coinbase
branch
from
3a50fef
to
094d5ac
Compare
| : null | ||
| } | ||
| <a href='https://itunes.apple.com/us/app/coinbase-bitcoin-wallet/id886427730?mt=8' target='_blank' id='appstoreLogo' /> | ||
| <a href='https://play.google.com/store/apps/details?id=com.coinbase.android' target='_blank' id='playstoreLogo' /> |
There was a problem hiding this comment.
why are we linking to the coinbase app for countries where coinbase is not supported?
| <span className='coinbaseMessage' data-l10n-id='coinbaseMessage' /> | ||
| <Button l10nId='done' className='pull-right whiteButton' onClick={this.props.hideParentOverlay} /> | ||
| </div> | ||
| } | ||
| } |
There was a problem hiding this comment.
should return null otherwise
jkup
force-pushed
the
bitcoin-without-coinbase
branch
from
094d5ac
to
18737a0
Compare
|
when my country code is FR, it tells me to buy btc through cubits but still shows the coinbase logo and footer. |
|
when my country code is |
|
@diracdeltas hmm that's a good catch. Perhaps there is something wrong with our approach. @mrose17 found a list of "supported countries" here https://www.coinbase.com/global but they don't all seem to be supported. |
|
2 options:
i'm inclined to believe |
|
@jkup - i agree with @diracdeltas |
|
@mrose17 @diracdeltas just to make sure I'm clear. We should do away with all of the checks for the user being in the US and only have whether or not they are in constants/coinbaseCountries? |
|
did i understand correctly today that the widget only works in the US but the coinbase apps work elsewhere? if so, this at least should change: browser-laptop/js/about/preferences.js Line 353 in f4418d6 |
jkup
force-pushed
the
bitcoin-without-coinbase
branch
from
18737a0
to
067f6a7
Compare
|
@diracdeltas I had a misunderstanding with the logic, should all be working now! |
|
lgtm |
git rebase -ito squash commits (if needed).Fix #4292
Test Plan:
Open Brave from a country where coinbase is not supported. I set my VPN to Israel. Then make sure the following changes occur in the add funds dialog.