Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Bookmark manager style update #4658

Merged
merged 6 commits into from
Oct 11, 2016
Merged

Bookmark manager style update #4658

merged 6 commits into from
Oct 11, 2016

Commits on Oct 11, 2016

  1. Updates to about:bookmarks 

    - Page is now styled! It looks similar to about:history
- Bookmark entries now shown in sortableTable (can't be re-ordered, but can be sorted)
- favicons are now shown
- URL is shown to right of bookmark on mouse over

Fixes #4562
Fixes #1994
    @bsclifton
    bsclifton committed Oct 11, 2016
    Configuration menu
    Copy the full SHA
    eea84e5 View commit details
    Browse the repository at this point in the history

  2. Integrated with multi-select (had to make a few tweaks)

    @bsclifton
    bsclifton committed Oct 11, 2016
    Configuration menu
    Copy the full SHA
    d7be320 View commit details
    Browse the repository at this point in the history

  3. Optimization for history page. Only one call per history date is made… 

    … now.

Auditors: @darkdh
    @bsclifton
    bsclifton committed Oct 11, 2016
    Configuration menu
    Copy the full SHA
    b469473 View commit details
    Browse the repository at this point in the history

  4. Bookmark manager no longer opens multiple tabs when double clicked 

    Fixes #4523

Also includes:
Update color of about:bookmarks from "been gone hunting" green to orange
    @bsclifton
    bsclifton committed Oct 11, 2016
    Configuration menu
    Copy the full SHA
    bc63ccd View commit details
    Browse the repository at this point in the history

  5. The refactoring done in #4361 unfortunately broke autofill. 

    This commit reverts the parts that broke it and keeps the parts that were OK.

Auditors: @darkdh @bridiver

Test Plan: follow steps from original PR
    @bsclifton
    bsclifton committed Oct 11, 2016
    Configuration menu
    Copy the full SHA
    41a1087 View commit details
    Browse the repository at this point in the history

  6. Reworking about:bookmarks after feedback from Brad. Still some more t… 

    …o do.
    @bsclifton
    bsclifton committed Oct 11, 2016
    Configuration menu
    Copy the full SHA
    3b730b9 View commit details
    Browse the repository at this point in the history