This repository has been archived by the owner on Dec 11, 2019. It is now read-only.
Handle different protocol prefixes in auto-suggest #5092
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Remove http and https from URLs when sorting * Increase history limit to 3, suggested to 3 * Update unit tests Auditors: @bbondy Test Plan: 1. Visit a mixture of sites that have a similar name (twitter.com, twilio.com) but have a different protocol prefix (http, https) 2. Ensure that history sorting is entirely based on count and frequency 3. Ensure that a maximum of 3 history items and 3 suggested sites are shown (so as not to overflow the space available and cause a scrollbar to appear) Fixes: #5091
bsclifton
reviewed
Oct 24, 2016
| @@ -107,5 +107,8 @@ module.exports.simpleDomainNameValue = (site) => { | |||
| * | |||
| */ | |||
| module.exports.normalizeLocation = (location) => { | |||
| return location.replace(/www\./, '') | |||
There was a problem hiding this comment.
Would it make more sense to use the window.URL object?
https://developer.mozilla.org/en-US/docs/Web/API/Window/URL
Also, another consideration would be if it makes sense to put the logic into our URL utils:
https://github.com/brave/browser-laptop/blob/master/js/lib/urlutil.js
There was a problem hiding this comment.
++ for extra logic in url utils but I'll merge this as is for now
This was referenced Oct 26, 2016
This was referenced Oct 27, 2016
This was referenced Oct 28, 2016
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
git rebase -ito squash commits (if needed).Auditors: @bbondy
Test Plan:
Fixes: #5091