Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Updating icons in URL bar #5449

Merged
merged 1 commit into from
Nov 7, 2016
Merged

Updating icons in URL bar #5449

merged 1 commit into from
Nov 7, 2016

Conversation

bsclifton
Copy link
Member

@bsclifton bsclifton commented Nov 7, 2016

  • Submitted a ticket for my issue if one did not already exist.
  • Used Github auto-closing keywords in the commit message.
  • Added/updated tests for this change (for new code or code which already has tests).
  • Ran git rebase -i to squash commits (if needed).

Updating icons in URL bar

Fixes #5446
Fixes #4910

  • includes updates to the webdriver tests (and adding new test case for this)
  • colors for icon in URL bar pulled out into variables.less

Auditors: @diracdeltas, @bbondy

Test Plan

  1. Launch Brave and open a new tab
  2. Notice that magnifying glass shows by default (with no text input yet)
  3. Type some text and notice icon remains magnifying glass (no longer the document icon)
  4. Visit http://mal-game.com
  5. Notice the triangle exclamation icon is now showing, since connection is HTTP
  6. Click the triangle in the URL bar and confirm you see the "insecure connection" modal
  7. Visit https://mixed-script.badssl.com/
  8. Click the lock icon in the URL bar
  9. Secure connection modal comes up. Click "Load Unsafe Scripts"
  10. Notice icon in URL bar is now the triangle
  11. Click the triangle icon in the URL bar and confirm you see the "partially insecure connection" modal

Screenshots

HTTP shows yellow triangle now
screen shot 2016-11-07 at 1 54 26 am

Insecure/partially insecure modal uses triangle
screen shot 2016-11-07 at 1 54 46 am
screen shot 2016-11-07 at 1 53 38 am

URL bar (when empty) now defaults to magnifying glass
screen shot 2016-11-07 at 2 00 48 am

when typing into URL bar, it shows magnifying glass instead of document
screen shot 2016-11-07 at 1 55 02 am

Fixes #5446
Fixes #4910

- includes updates to the webdriver tests (and adding new test case for this)
- colors for icon in URL bar pulled out into variables.less

Auditors: @diracdeltas, @bbondy

Test Plan:
1. Launch Brave and open a new tab
2. Notice that magnifying glass shows by default (with no text input yet)
3. Type some text and notice icon remains magnifying glass (no longer the document icon)
4. Visit http://mal-game.com
5. Notice the triangle exclamation icon is now showing, since connection is HTTP
6. Click the triangle in the URL bar and confirm you see the "insecure connection" modal
7. Visit https://mixed-script.badssl.com/
8. Click the lock icon in the URL bar
9. Secure connection modal comes up. Click "Load Unsafe Scripts"
10. Notice icon in URL bar is now the triangle
11. Click the triangle icon in the URL bar and confirm you see the "partially insecure connection" modal
@bsclifton bsclifton added polish Nice to have — usually related to front-end/visual tasks. feature/URLbar labels Nov 7, 2016
@bsclifton bsclifton added this to the 0.12.9dev milestone Nov 7, 2016
@bbondy
Copy link
Member

bbondy commented Nov 7, 2016

excellent, thanks!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants