Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Navigation bar no longer centered #5615

Merged
merged 1 commit into from
Nov 15, 2016
Merged

Navigation bar no longer centered #5615

merged 1 commit into from
Nov 15, 2016

Conversation

jkup
Copy link
Contributor

@jkup jkup commented Nov 14, 2016

  • Submitted a ticket for my issue if one did not already exist.
  • Used Github auto-closing keywords in the commit message.
  • Added/updated tests for this change (for new code or code which already has tests).
  • Ran git rebase -i to squash commits (if needed).

Auditors: @bsclifton @bradleyrichter

Fix #5476

Test Plan:

  1. Open Brave
  2. Make sure urlbar and it's buttons are almost centered to the browser window.

Note* I realize there is a 5px difference or so because the left section is a bit smaller than the right but it should be good enough for now :)

@jkup jkup added this to the 0.12.10 release milestone Nov 14, 2016
@bsclifton
Copy link
Member

bsclifton commented Nov 14, 2016

LGTM 😄 Did you want to check this out before merge, @bradleyrichter?

On my Thunderbolt monitor, I maxed out the window and here's the pixel count:

  • 864 pixels to the from left of the favicon star to the edge of screen
  • 848 on from right of URL bar to the edge of the screen

dead on (within a few pixels) if I measure:

  • from left of URL bar (not counting favicon) to right of <> buttons
  • from right of URL bar to the end icons

Here's a screencap:
screen shot 2016-11-14 at 3 23 21 pm

@bsclifton
Copy link
Member

bsclifton commented Nov 14, 2016

updated my previous comment 😄 NOTE: I rebased your commit, added the closing keywords to the commit (ex: just the "Fix #5476"), and checked the boxes at the top of the PR 😄

@bsclifton
Copy link
Member

Merging 😄 Thanks!

@bsclifton bsclifton merged commit 44ee155 into master Nov 15, 2016
@bsclifton bsclifton deleted the urlbar-centering branch November 15, 2016 20:41
@bradleyrichter
Copy link
Contributor

just make sure we hang onto the right-end zone padding which becomes a grab area when the width is minimal.

@jkup
Copy link
Contributor Author

jkup commented Nov 15, 2016

Yep that's still there. Just in a media query now

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants