Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Animate fadeIn of titlebar buttons #5667

Merged
merged 1 commit into from
Nov 21, 2016
Merged

Animate fadeIn of titlebar buttons #5667

merged 1 commit into from
Nov 21, 2016

Conversation

cndouglas
Copy link

  • Submitted a ticket for my issue if one did not already exist.
  • Used Github auto-closing keywords in the commit message.
  • Added/updated tests for this change (for new code or code which already has tests).
  • Ran git rebase -i to squash commits (if needed).

Test Plan:

  1. Make sure "Always show the URL bar" is turned off in preferences.
  2. Also make sure "Show Home button on URL bar" is turned on in Preferences.
  3. Open a new tab and navigate to any site.
  4. Hover over the titlebar.
  5. Make sure the reload button and home button fade in with the urlbar.

Fixes #5664

@luixxiul
Copy link
Contributor

luixxiul commented Nov 16, 2016

Actually I'd prefer this, because there would/could be other buttons added and the buttons name could be changed.

  &:not(.titleMode) {
    .urlbarForm,
    .bookmarkButtonContainer,
    span[class$="Button"] {
      animation: fadeIn .6s;
      opacity: 0;
      animation-fill-mode: forwards;
    }

@luixxiul luixxiul added the design A design change, especially one which needs input from the design team. label Nov 16, 2016
@cndouglas
Copy link
Author

@luixxiul Great! We can close this if you want to submit a PR with that code.

@luixxiul
Copy link
Contributor

luixxiul commented Nov 16, 2016

You can create another commit, squash two commits, and git push -f to overwrite the commit above.

@cndouglas
Copy link
Author

OK, will do.

@cndouglas cndouglas changed the title Animate fadeIn of reload, stop, and home buttons Animate fadeIn of titlebar buttons Nov 16, 2016
@cndouglas
Copy link
Author

Done. Works fine based on my testing.

@luixxiul
Copy link
Contributor

++

@bsclifton
Copy link
Member

Great catch 😄 I tried it out, looks good!

@luixxiul
Copy link
Contributor

This was superseded by #6326

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
design A design change, especially one which needs input from the design team. feature/navbar misc/button QA/no-qa-needed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants