Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Fixed edit bookmark hanger showing when adding bookmark #5717

Merged
merged 1 commit into from
Nov 22, 2016
Merged

Fixed edit bookmark hanger showing when adding bookmark #5717

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion js/contextMenus.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,7 @@ const addBookmarkMenuItem = (label, siteDetail, closestDestinationDetail, isPare
if (isParent) {
siteDetail = siteDetail.set('parentFolderId', closestDestinationDetail && (closestDestinationDetail.get('folderId') || closestDestinationDetail.get('parentFolderId')))
}
windowActions.setBookmarkDetail(siteDetail, siteDetail, closestDestinationDetail, true)
windowActions.setBookmarkDetail(siteDetail, siteDetail, closestDestinationDetail, false, true)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should still show the location when you use this option, but it should show as add bookmark and not edit bookmark.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should it only show the location if you already have the site bookmarked (similar to the star behavior)? Or always show the location when you cmd+d or select it from the menu?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add bookmark on the toolbar is not or adding a bookmark for the current page, it is more generalized. You can default the values to the current page but it's designed to add a bookmark for any page.

}
}
}
Expand Down