This repository has been archived by the owner on Dec 11, 2019. It is now read-only.
Add user-friendly title for about:blank #5782
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Auditors: @bsclifton, @bradleyrichter, @srirambv Fix #5764 Test Plan: * Set new tab opens with my homepage * Clear the homepage field * Open a new tab * New tab title must be about:blank * Navigate to a site on that tab and long press the back navigation button. Title inside contextMenu should be "about:blank"
|
Manually tested this; looks great 😄 ++ |
|
@cezaraugusto if you wanted bonus points, you should be able to automate the test for this w/ webdriver 🤖 |
This was referenced Dec 12, 2016
This was referenced Dec 21, 2016
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
git rebase -ito squash commits (if needed).Test Plan:
Auditors: @bsclifton, @bradleyrichter, @srirambv
Fix #5764
Test Plan