Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Removed "inlineButton" from Cancel button on Brave wallet recovery dialog #5805

Merged
merged 1 commit into from
Nov 24, 2016
Merged

Removed "inlineButton" from Cancel button on Brave wallet recovery dialog #5805

merged 1 commit into from
Nov 24, 2016

Conversation

luixxiul
Copy link
Contributor

  • Submitted a ticket for my issue if one did not already exist.
  • Used Github auto-closing keywords in the commit message.
  • Added/updated tests for this change (for new code or code which already has tests).
  • Ran git rebase -i to squash commits (if needed).

Fix #5804 into
screenshot 2016-11-23 13 17 04

Auditors: @bbondy

Test Plan:

  1. Open about:preferences#payments
  2. Click "Recover your wallet"

Removed "inlineButton" from Cancel button on Brave wallet recovery di…
2a031ed 
…alog

Fix #5804

Auditors: @bbondy

Test Plan:
1. Open about:preferences#payments
2. Click "Recover your wallet"
@luixxiul luixxiul added this to the 0.13.0 milestone Nov 23, 2016
@bbondy
Copy link
Member

bbondy commented Nov 24, 2016

++

@bbondy bbondy merged commit 1c6725b into brave:master Nov 24, 2016
@luixxiul luixxiul deleted the payment-cancelButton branch November 24, 2016 20:27
This was referenced Dec 12, 2016
Closed
Closed
This was referenced Dec 20, 2016
Closed
Closed
Closed
Closed
@luixxiul
Copy link
Contributor Author

Labelled QA/no qa needed because this was superseded with #6216

@luixxiul
Copy link
Contributor Author

Labelled release-notes/exclude because the bug was introduced and fixed in the same milestone.

@luixxiul luixxiul mentioned this pull request Jun 3, 2017
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
feature/rewards misc/button
Projects
None yet
Milestone
0.13.0
Development

Successfully merging this pull request may close these issues.
2 participants
@luixxiul @bbondy