Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Clean up formatting for bitcoin wallet backup #5862

Merged
merged 1 commit into from
Nov 27, 2016
Merged

Conversation

jkup
Copy link
Contributor

@jkup jkup commented Nov 27, 2016

  • Submitted a ticket for my issue if one did not already exist.
  • Used Github auto-closing keywords in the commit message.
  • Added/updated tests for this change (for new code or code which already has tests).
  • Ran git rebase -i to squash commits (if needed).

Fix #4807

Auditors @bsclifton @bbondy

Test Plan

  1. Open Brave
  2. Go to Preferences > Payments
  3. Click Advanced Settings
  4. Try both Printing and Saving your backup keys. They should look like the screenshots below.

screen shot 2016-11-27 at 3 17 00 pm

screen shot 2016-11-27 at 3 17 19 pm

@jkup jkup added design A design change, especially one which needs input from the design team. feature/rewards QA/test-plan-specified labels Nov 27, 2016
@jkup jkup added this to the 0.13.0 milestone Nov 27, 2016
@bsclifton
Copy link
Member

Tested out the change, looks good! This might be a good one for a unit test (if you wanted to do that as a follow up; totally optional 😄 ). The formatting logic could be broken out into ledgerUtil. This would let us easily test different inputs (null, undefined, not string, etc) to ensure none of them cause a problem

Merging! 😄

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
design A design change, especially one which needs input from the design team. feature/rewards
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants