Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Follow-up: Button styles consistent #6001

Merged
merged 1 commit into from
Dec 3, 2016
Merged

Follow-up: Button styles consistent #6001

merged 1 commit into from
Dec 3, 2016

Conversation

luixxiul
Copy link
Contributor

@luixxiul luixxiul commented Dec 3, 2016

  • Submitted a ticket for my issue if one did not already exist.
  • Used Github auto-closing keywords in the commit message.
  • Added/updated tests for this change (for new code or code which already has tests).
  • Ran git rebase -i to squash commits (if needed).

Based on #5916 (comment) this fixes

  • Margin-bottom of the brave wallet address

screenshot 2016-12-03 12 53 35

  • Avoided button text from overflowing (l10n-friendly)

screenshot 2016-12-03 12 56 47

Auditors: @bradleyrichter

Test Plan:

  1. Open about:preferences#payments
  2. Make sure that there is margin-bottom set to the brave wallet address
  3. Change the lang setting into Japanese
  4. Make sure that the buttons on about:preferences#payments no longer overflow

Based on #5916 (comment) this fixes

- Margin-bottom of the brave wallet address
- Button text overflow (l10n-friendly)

Auditors: @bradleyrichter

Test Plan:
@luixxiul
Copy link
Contributor Author

I created the issue for QA: #6675

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants