input and select are not equal width

[jkup]

• Submitted a ticket for my issue if one did not already exist.
• Used Github auto-closing keywords in the commit message.
• Added/updated tests for this change (for new code or code which already has tests).
• Ran git rebase -i to squash commits (if needed).

TIL that select boxes aren't box-sizing: border-box like input elements are which is causing them to be wider than they should be if they have padding. The easy fix is just manually setting all inputs and selects to border-box (this is what Bootstrap does, although they apply it to the entire html selector!)

Fix #5192

Auditors @bradleyrichter @bsclifton

Test Plan:

1. Open Brave
2. Add a bookmark on Bookmark toolbar
3. Make sure the Title and Folder are the same width
4. Open about:bookmarks
5. Cick the star icon on the page
6. Make sure three rows are the same width

[luixxiul]

Cherry-picked and pushed the commits of #5837 to fix the dialog on about:bookmarks

into

[bradleyrichter]

Bonus points for replacing that heavy black close button with the svg from the stop loading button. : )

…

On Dec 5, 2016, at 9:43 PM, Suguru Hirahara ***@***.***> wrote: Cherry-picked and pushed the commits of #5837 to fix the dialog on about:bookmarks into — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or mute the thread.

[luixxiul]

@bsclifton would you please apply modalOverlay to the modal dialog on about:bookmarks? It will make it possible for us to use modalOverlay.js and modalOverlay.less, which would help to make the style more consistent, including margins and paddings :-) (I thought you have implemented the dialog. Sorry if I'm wrong!)

@bradleyrichter I have replaced the close button for the modal dialog with the SVG button in 21ece29#diff-a12551e83f49ce14bb3d831f382ff9acR106 of #6009.

[luixxiul]

@bsclifton @bradleyrichter I opened an issue for that: #6040

[bbondy]

++