Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Replaced fa-times for close button on download bar with SVG button #6071

Merged
merged 1 commit into from
Dec 8, 2016
+14 −3
Merged

Replaced fa-times for close button on download bar with SVG button #6071

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions img/toolbar/close_download_btn.svg
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
1 change: 1 addition & 0 deletions img/toolbar/close_download_btn_hover.svg
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
3 changes: 1 addition & 2 deletions js/components/downloadsBar.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -134,8 +134,7 @@ class DownloadsBar extends ImmutableComponent {
}
</div>
<div className='downloadBarButtons'>
<Button iconClass='fa-times'
className='downloadButton smallButton hideButton'
<Button className='downloadButton'
onClick={downloadActions.hideDownloadsToolbar} />
</div>
</div>
Expand Down
12 changes: 11 additions & 1 deletion less/downloadBar.less
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -132,7 +132,17 @@
margin: auto 0;

.downloadButton {
margin: 0 2px;
background: url('../img/toolbar/close_download_btn.svg') center no-repeat;
background-size: 14px 14px;
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bradleyrichter Are these too large?

height: 18px;
width: 18px;

&:hover {
background: url('../img/toolbar/close_download_btn_hover.svg') center no-repeat;
background-size: 14px 14px;
height: 18px;
width: 18px;
}

&.hideButton:not([disabled]):hover {
background: @chromeControlsWarningBackground;
Expand Down