Added dock menu for macOS #6087
Conversation
|
I would also like to add New private window option, but as far as I can see Brave don't have this option. Any suggestions how to achieve this? |
|
@NejcZdovc Works great, thanks! Since New Private Window is not implemented yet, I think it can be left out for now. (Tracked under #1288.) |
| return [ | ||
| { | ||
| label: locale.translation('newWindow'), | ||
| accelerator: 'CmdOrCtrl+N', |
There was a problem hiding this comment.
do we need accelerator for dock menu?
There was a problem hiding this comment.
@darkdh no, I don't think we do; I believe it may have been copy/pasted on accident
Here is the API doc for reference:
http://electron.atom.io/docs/tutorial/desktop-environment-integration/#custom-dock-menu-macos
There was a problem hiding this comment.
@ NejcZdovc, I think we should remove accelerator.
There was a problem hiding this comment.
Sure, it's removed.
Resolves brave#3024 Added doc menu for macOS with items: - new window Auditors: @bbondy, @bsclifton Test Plan: Open Brave on macOS. Right click on the icon in the dock. There should be a menu item named "New window". Clicking on it should open new Brave window.
NejcZdovc
force-pushed
the
feature/doc-menu
branch
from
8b380a7
to
688aab1
Compare
|
good job! Thanks |
|
Very cool- thanks, @NejcZdovc! 😄 |
git rebase -ito squash commits (if needed).Description
Resolves #3024. As far as I can see the second part of this issue the list of windows is already done.
Added doc menu for macOS with items:
Auditors
@bbondy, @bsclifton
Test Plan
Open Brave on macOS. Right click on the icon in the dock. There should be a menu item named "New window". Clicking on it should open a new Brave window.