This repository has been archived by the owner on Dec 11, 2019. It is now read-only.
Small changes of the icons on about pages #6138
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On about:bookmarks - Aligned fa-file-o favicon on about:bookmarks On about:preferences#security - Restyled widevineInfo (line-height, paddings around the icons, cursor:pointer on them) Closes #6137 Auditors: @bbondy @bradleyrichter Test Plan: 1. Bookmark about:newtab 2. Open about:bookmarks 3. Make sure the favicon of the bookmarked new tab has 16px width 4. Open about:preferences#security 5. Make sure the icons below "Plugin Settings" are indented 6. Check the line-height of the subtexts in Google Widevine Support 7. Check the cursor on the two info icons
luixxiul
added
the
polish
|
nice polish! |
This was referenced Dec 20, 2016
This was referenced Jan 16, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
git rebase -ito squash commits (if needed).On about:bookmarks
On about:preferences#security
Closes #6137
Auditors: @bbondy @bradleyrichter
Test Plan: