This repository has been archived by the owner on Dec 11, 2019. It is now read-only.
Setting min-width for buttons #6387
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Per @bradleyrichter the min-width was set to 6 times the default character's size Closes #6384 Auditors: @bradleyrichter @bsclifton @jkup Test Plan: 1. Open about:autofill 2. Click "Add Address" 3. Make sure the width of the button "Cancel" and "Save" is equal
luixxiul
added
misc/button
polish
bbondy
reviewed
Dec 22, 2016
| @@ -82,6 +82,7 @@ span.buttonSeparator { | |||
| padding-bottom: 5px; | |||
| width: auto; | |||
| height: auto; | |||
| min-width: calc(@defaultFontSize * 6); // issue #6384 | |||
There was a problem hiding this comment.
Is it possible there are some buttons this will make unexpectedly bigger than what it was?
There was a problem hiding this comment.
As far as I can tell via the picture on #6384 (comment) where you see primaryButton, .actionButton, .wideButton, .subtleButton, and .whiteButton, I don't think so.
|
ok thanks. ++ |
This was referenced Dec 30, 2016
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
git rebase -ito squash commits (if needed).Per @bradleyrichter the min-width was set to 6 times the default character's size
Closes #6384
Auditors:
Test Plan:
into