This repository has been archived by the owner on Dec 11, 2019. It is now read-only.
add noScriptInfo checkboxes to allow scripts by origin #7272
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bbondy
suggested changes
Feb 21, 2017
docs/appActions.md
Outdated
| @@ -660,6 +660,18 @@ Dispatches a message when a tab is being cloned | |||
|
|
|||
|
|
|||
|
|
|||
| ### setNoScriptExceptions(hostPattern, origins) | |||
There was a problem hiding this comment.
we're trying to avoid set* names for actions, and name them after an event instead. Could you rename this to noScriptExceptionAdded or something similar?
js/actions/appActions.js
Outdated
| */ | ||
| setNoScriptExceptions: function (hostPattern, origins) { | ||
| AppDispatcher.dispatch({ | ||
| actionType: appConstants.APP_SET_NOSCRIPT_EXCEPTIONS, |
|
|
||
| .truncate { | ||
| margin-bottom: 5px; | ||
| } | ||
| .noScriptCheckbox { |
There was a problem hiding this comment.
We're using aphrodite for new UI but since this isn't new UI and just an extension of an existing one this is cool. Feel free to update at the same time to aphrodite if you want to.
|
ack sorry I had review comments pending and didn't notice. |
diracdeltas
force-pushed
the
fix/6431
branch
from
71869c8
to
1268f00
Compare
|
@bbondy addressed review comments |
|
++ |
This was referenced Mar 1, 2017
|
Why is there no option to permanently whitelist domains for script execution? It's not a great user experience to have to re-enable scripts for my internet banking every time I restart my browser. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
test plan:
fix #6431. adjusts the noScriptInfo dialog so that it can be used to allow scripts by origin, instead of all scripts on the page, when NoScript is globally enabled. removes the option to allow scripts persistently (since this can be done via the Bravery panel anyway)
auditors: @bbondy
git rebase -ito squash commits (if needed).