Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Add session-tab icon numbers #7652

Merged
merged 1 commit into from
Mar 11, 2017
Merged

Add session-tab icon numbers #7652

merged 1 commit into from
Mar 11, 2017

Conversation

cezaraugusto
Copy link
Contributor

@cezaraugusto cezaraugusto commented Mar 11, 2017

  • Submitted a ticket for my issue if one did not already exist.
  • Used Github auto-closing keywords in the commit message.
  • Added/updated tests for this change (for new code or code which already has tests).
  • Ran git rebase -i to squash commits (if needed).

Auditors: @bsclifton, @bbondy

Fix #7367
Fix #3083

screen shot 2017-03-10 at 1 28 51 pm

Note: this visually blocks sessions higher than 9 due to UI limitations.
/cc @bradleyrichter

Test Plan:

npm run test -- --grep="should show partition number for new sessions"
npm run test -- --grep="should show max partition number even if session is bigger"

@cezaraugusto cezaraugusto added this to the 0.13.6 milestone Mar 11, 2017
@cezaraugusto cezaraugusto self-assigned this Mar 11, 2017
}

module.exports = {
tabs
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pls remove this file and instead just put the value in js/constants/config.js

@bbondy
Copy link
Member

bbondy commented Mar 11, 2017

This is really great, thanks @cezaraugusto. Please do submenus too for this version. See Slack convo with @bradleyrichter. There's one nit only but I'm merging independent of it.

@bbondy bbondy merged commit e5438c1 into brave:master Mar 11, 2017
@cezaraugusto cezaraugusto deleted the tabsbar/7367 branch July 25, 2017 07:25
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants