Replace float:right with flex model on alert dialogs #7674

luixxiul · 2017-03-13T05:50:52Z

Test Plan:

Submitted a ticket for my issue if one did not already exist.
Used Github auto-closing keywords in the commit message.
Added/updated tests for this change (for new code or code which already has tests).
Ran git rebase -i to squash commits (if needed).

Follow-up of #7107 (#7107 (comment)) Closes #7673 Auditors: Test Plan: 1. Visit http://jsbin.com/fiyojusahu/edit?html,output 2. In the `output` area, click the `Click me to test an alert` button 3. Make sure the buttons are aligned to the right 4. Visit http://jsbin.com/sadunogefu/edit?html,output 5. In the `output` area, click the `Click me to test a confirm` button 6. Make sure the buttons are aligned to the right

bsclifton

Manually tested on Windows 10, looks great! 😄

cezaraugusto

++

luixxiul added misc/button polish Nice to have — usually related to front-end/visual tasks. labels Mar 13, 2017

luixxiul added this to the 0.13.6 milestone Mar 13, 2017

luixxiul self-assigned this Mar 13, 2017

luixxiul requested review from cezaraugusto and bsclifton March 13, 2017 05:50

bsclifton approved these changes Mar 13, 2017

View reviewed changes

bsclifton merged commit 3378e7f into brave:master Mar 13, 2017

cezaraugusto reviewed Mar 13, 2017

View reviewed changes

luixxiul deleted the alert-button-flexmodel branch March 14, 2017 01:44