Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

remove Brave from autosuggest and history (again) #7753

Merged
merged 1 commit into from
Mar 17, 2017
Merged

Conversation

diracdeltas
Copy link
Member

@diracdeltas diracdeltas commented Mar 16, 2017

fix #7655

Test Plan:

  1. automated tests should pass
  2. open clean instance of brave
  3. type 'fa' into urlbar. you should not see brave's facebook page in the autosuggest.
  4. go to about:history. there should be no brave sites.
  • Submitted a ticket for my issue if one did not already exist.
  • Used Github auto-closing keywords in the commit message.
  • Added/updated tests for this change (for new code or code which already has tests).
  • Ran git rebase -i to squash commits (if needed).

Test Plan:

fix #7655

Test Plan:
1. automated tests should pass
2. open clean instance of brave
3. type 'fa' into urlbar. you should not see brave's facebook page in the autosuggest.
4. go to about:history. there should be no brave sites.
@diracdeltas diracdeltas added this to the 0.14.0 milestone Mar 16, 2017
@diracdeltas diracdeltas requested a review from bsclifton March 16, 2017 22:05
Copy link
Member

@bsclifton bsclifton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look great! 😄 I ran the automated tests and then also ran some manual tests. Everything works as expected 👍 Let me confirm with @bradleyrichter and if he's good with it, let's merge 😄 Thanks!

@bradleyrichter
Copy link
Contributor

Cool. this keeps pre-loading tiles flexibility? Thanks @diracdeltas !

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fixed fresh install of Brave advertises Brave properties
3 participants