Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Add variables for the improved flat top panel #7804

Merged
merged 1 commit into from
Mar 26, 2017
Merged

Add variables for the improved flat top panel #7804

merged 1 commit into from
Mar 26, 2017

Conversation

luixxiul
Copy link
Contributor

@luixxiul luixxiul commented Mar 21, 2017

Follow-up of #7740
Addresses #7739

  • Updated existing variables in global.js
  • navbarMenubarMargin = tabPagesHeight

Auditors:

Test Plan: #7740 (comment)

  • Submitted a ticket for my issue if one did not already exist.
  • Used Github auto-closing keywords in the commit message.
  • Added/updated tests for this change (for new code or code which already has tests).
  • Ran git rebase -i to squash commits (if needed).

Test Plan:

Follow-up of #7740
Addresses #7739

- Updated existing variables in global.js
- navbarMenubarMargin = tabPagesHeight

Auditors:

Test Plan: #7740 (comment)
@luixxiul luixxiul added the polish Nice to have — usually related to front-end/visual tasks. label Mar 21, 2017
@luixxiul luixxiul self-assigned this Mar 21, 2017
@@ -622,7 +622,7 @@
.navigatorWrapper {
justify-content: space-between;
align-items: center;
margin-top: 7px;
margin-top: @navbarMenubarMargin;
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

between the top edge of a window and the URL bar

justify-content: center;
height: @tabPagesHeight;
padding: @tabPagesHeight 0 @navbarMenubarMargin 0;
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • between the bookmark toolbar and the tab pages
  • between the tab pages and the tabsbar

@luixxiul luixxiul added this to the 0.14.1 milestone Mar 21, 2017
@luixxiul luixxiul requested a review from NejcZdovc March 23, 2017 17:24
Copy link
Contributor

@cezaraugusto cezaraugusto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested on macOS, LGTM

@luixxiul luixxiul merged commit c920701 into brave:master Mar 26, 2017
@luixxiul luixxiul deleted the flat-followup branch March 26, 2017 16:09
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
polish Nice to have — usually related to front-end/visual tasks.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants