This repository has been archived by the owner on Dec 11, 2019. It is now read-only.
Refactor notificationBar & updateBar #7831
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closes #7853 Instead of applying float:right to place the buttons (span className='options') to the right, separate the buttons wrapper and the other elements, and place them with display:flex and justify-content:space-between (styles.flexJustifyBetween) . Fix #6749 Remove updateBar.less, adding notificationBar__greetingStyle to commonStyles.js Unify the className 'primaryButton' - Renamed 'buttonPrimary' to 'primaryButton' on commonStyles.js and app/renderer/components/preferences/payment/*.js - Renamed 'primary' to 'primaryButton' on app/ledger.js Add styles to commonStyles.js - notificationBar - notificationBar__notificationItem - Introduce border-box - notificationBar__greetingStyle - notificationItem__greeting - notificationItem__message - notificationItem__secondaryMessage - notificationItem__button Add a style to global.js - 'tabsToolbarBorderColor' (unify the border color of the buttons and the tabs toolbar) - 'navbarMenubarMargin' Replace 'button' with 'css(commonStyles.notificationItem__button)' TODO: Refactor button.less to remove 'browserButton', 'whiteButton', and 'primaryButton' from notificationBar.js and updateBar.js Change data-test-id='options' to data-test-id='notificationOptions' on notificationBar.js Add data-test-ids to updateBar.js - data-test-id='updateHide' - data-test-id='updateDetails' - data-test-id='updateLater' - data-test-id='updateNow' Reduce button's line-height to 1 Auditors: Test Plan: 1. Close the browser 2. Edit <UpdateNotAvailable> to <UpdateAvailable> on updateBar.js 3. Edit ledger-state.json to display the ledger notification bar 4. Open the browser 5. Check for update... 6. Open https://browserleaks.com/geo 7. Wait until the ledger notification bar appears
luixxiul
changed the title
|
I missed that #6939 was under WIP. |
bsclifton
approved these changes
Mar 23, 2017
bsclifton
added
QA/test-plan-specified
release-notes/include
and removed
PR/needs-QA-attention ☕
labels
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactor notificationBar & updateBar (including the ledger notification bar which was implemented by @ayumi with PR #3856 of the issue #3257) with aphrodite.
From:
To:
Closes #7853
Auditors:
Test Plan:
<UpdateNotAvailable>to<UpdateAvailable>on updateBar.jsgit rebase -ito squash commits (if needed).Test Plan: