This repository has been archived by the owner on Dec 11, 2019. It is now read-only.
Increase the tabs bar and tabsToolbarButtons height #8300
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closes #8263 Auditors: Test Plan: 1. Open github.com 2. Open facebook.com in a new tab 3. Open about:preferences in a new tab 4. Turn on the tab theme option 5. Make sure the tab looks good 6. Ensure drag and drop still works good for moving tabs around 7. Ensure other features still look good; for example, bookmarks toolbar 8. Ensure the menu button on the tabs bar still works good
luixxiul
commented
Apr 13, 2017
| @@ -210,4 +210,6 @@ globalStyles.color.activeTabDefaultColor = globalStyles.color.chromePrimary | |||
| globalStyles.color.switchBG_on = globalStyles.color.braveOrange | |||
| globalStyles.color.statsGray = globalStyles.color.chromeText | |||
|
|
|||
| globalStyles.spacing.tabHeight = globalStyles.spacing.tabsToolbarHeight | |||
There was a problem hiding this comment.
Actually globalStyles.spacing.tabsToolbarHeight is not yet used anywhere else (as the tabs bar is yet to be refactored with Aphrodite).
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #8263
Auditors:
Test Plan:
git rebase -ito squash commits (if needed).#7740 (comment)