This repository has been archived by the owner on Dec 11, 2019. It is now read-only.
Fixes #8540 - Added "Mute All", Fixed "Mute Other Tabs", made "(Un)Mu… #8623
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #8540 - Added "Mute All", Fixed "Mute Other Tabs", made "(Un)Mute Tab" always present, changed Mute icon display behavior.
git rebase -i
to squash commits (if needed).Test Plan:
This PR contains several things, many of which weren't discussed in #8540. I probably shoved more stuff into this than I should have and I'm happy to have any and all ideas shot down -- I'm mainly doing this to familiarize myself with javascript and github.
Lastly, I would suggest like to suggest that the mute icon be made less ambiguous.
vs seems obvious until you realize that if the first one isn't present as a comparison that the second one simply looks like a speaker. The user doesn't know that it's missing the sound waves emanating from the speaker. I would propose an icon with the speaker slashed out.