This repository has been archived by the owner on Dec 11, 2019. It is now read-only.
Remove paymentStyles.margin.bar, margin.barItem, padding.bar #8710
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
in favor of globalStyles.spacing.panelMargin, globalStyles.spacing.panelItemMargin, globalStyles.spacing.panelPadding Addresses #8661 preferences.less - move anchor properties under .paymentContainer to .prefBody payment styles - replace '.paymentContainer th' with paymentStyles.tableHeader payment styles - remove .paymentsContainer from preferences.less This commit finally removes the legacy code under paymentsContainer since #6009 and #6047. Test Plan 1: 1. Open about:preferences#payments 2. Hover the anchor links (question marks and domains in the ledger table) 3. Make sure they are underlined Test Plan 2: 1. Open about:preferences#payments 2. Make sure that the ledger table is not broken Test Plan 3: 1. Open about:preferences#payments 2. Make sure 'monthly budget' and 'account budget' is bolded 3. Make sure the ledger table header is bolded (it is by design) 4. Open payment history 5. Make sure the table header is bolded
cezaraugusto
approved these changes
May 5, 2017
Closed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
in favor of
globalStyles.spacing.panelMargin,
globalStyles.spacing.panelItemMargin,
globalStyles.spacing.panelPadding
Closes #8722 (comment)
Addresses #8661
preferences.less - move anchor properties under .paymentContainer to .prefBody
payment styles - replace '.paymentContainer th' with paymentStyles.tableHeader
payment styles - remove .paymentsContainer from preferences.less
This commit finally removes the legacy code under paymentsContainer since #6009 and #6047.
Test Plan 1:
Test Plan 2:
Test Plan 3:
git rebase -ito squash commits (if needed).Test Plan: