Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Address feedback in PR #8894 #8951

Merged
merged 1 commit into from
May 19, 2017
Merged

Address feedback in PR #8894 #8951

merged 1 commit into from
May 19, 2017

Conversation

ayumi
Copy link
Contributor

@ayumi ayumi commented May 19, 2017

#8894

Auditors: @bbondy

Test Plan:
Check that automated tests pass.

Submitter Checklist:

  • Submitted a ticket for my issue if one did not already exist.
  • Used Github auto-closing keywords in the commit message.
  • Added/updated tests for this change (for new code or code which already has tests).
  • Ran git rebase -i to squash commits (if needed).

Test Plan:

Reviewer Checklist:

Tests

  • Adequate test coverage exists to prevent regressions
  • Tests should be independent and work correctly when run individually or as a suite ref
  • New files have MPL2 license header

Auditors: @bbondy

Test Plan:
Check that automated tests pass.
@luixxiul luixxiul added this to the 0.15.300 milestone May 19, 2017
@@ -96,7 +96,6 @@ class NewTabPage extends React.Component {
}).size > 0
}
isBookmarked (siteProps) {
// XXX: Fixme, not passing state in!
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you check if this gets called frequently?

Copy link
Contributor Author

@ayumi ayumi May 19, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did check. It gets called once per newtab tab square, but it runs in <= 1ms.

@bbondy
Copy link
Member

bbondy commented May 19, 2017

++

@bbondy bbondy merged commit 00e2a0c into master May 19, 2017
bbondy added a commit that referenced this pull request May 19, 2017
@bsclifton bsclifton deleted the fix/improve-8894 branch May 19, 2017 22:40
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants