-
Notifications
You must be signed in to change notification settings - Fork 973
Conversation
@@ -40,6 +43,7 @@ class Dialog extends ImmutableComponent { | |||
render () { | |||
return <div className={cx({ | |||
dialog: true, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is it needed somewhere? we are removing style class and I can't see any test using it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
oops I just forgot to check that out. I'm going to remove it, thanks.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed with 3ba6110
} | ||
} | ||
} | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can't get enough of less less :)
I would recommend removing |
My bad, that conversion breaks the bookmarkHanger (which I often forget that it is also a component with Dialog). Fortunately the change is not available on 0.15.300 series, so I'm fixing it before 0.16.100. thanks! |
Closes #8984
Per 2dd92a9, dialog.less can be safely removed (as styles under 'menu' has been just copied).
Test Plan:
Submitter Checklist:
git rebase -i
to squash commits (if needed).Reviewer Checklist:
Tests