Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Replace menu_btn #9363

Merged
merged 1 commit into from
Jun 19, 2017
Merged

Replace menu_btn #9363

merged 1 commit into from
Jun 19, 2017

Conversation

luixxiul
Copy link
Contributor

@luixxiul luixxiul commented Jun 9, 2017 •
edited
Loading

Closes #9305

Auditors:

Test Plan:

  1. Make sure the menu button on the tabs bar is replaced

Submitter Checklist:

  • Submitted a ticket for my issue if one did not already exist.
  • Used Github auto-closing keywords in the commit message.
  • Added/updated tests for this change (for new code or code which already has tests).
  • Ran git rebase -i to squash commits (if needed).
  • Tagged reviewers and labelled the pull request as needed.

Reviewer Checklist:

Tests

  • Adequate test coverage exists to prevent regressions
  • Tests should be independent and work correctly when run individually or as a suite ref
  • New files have MPL2 license header

Replace menu_btn
df48c7e 
Closes #9305

Auditors:

Test Plan:
1. Make sure the menu button on the tabs bar is replaced
@luixxiul luixxiul self-assigned this Jun 9, 2017
@luixxiul luixxiul requested a review from cezaraugusto June 9, 2017 16:25
@luixxiul luixxiul added this to the 0.19.x (Nightly Channel) milestone Jun 13, 2017
cezaraugusto
cezaraugusto reviewed Jun 19, 2017
View reviewed changes
img/toolbar/menu_btn.svg
<?xml version="1.0" encoding="utf-8"?>
<!-- Generator: Adobe Illustrator 21.1.0, SVG Export Plug-In . SVG Version: 6.00 Build 0) -->
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hah "I Know What You Did Last Summer"

cezaraugusto
cezaraugusto approved these changes Jun 19, 2017
View reviewed changes
Copy link
Contributor

@cezaraugusto cezaraugusto left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

++ I'm sure @bradleyrichter will love this

@cezaraugusto cezaraugusto merged commit 279f27f into brave:master Jun 19, 2017
@cezaraugusto cezaraugusto deleted the polish-kabab branch June 19, 2017 01:29
@bradleyrichter bradleyrichter mentioned this pull request Jun 19, 2017
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@cezaraugusto cezaraugusto cezaraugusto approved these changes

Assignees

@luixxiul luixxiul

Labels
accessibility misc/button
Projects
None yet
Milestone
0.19.x (Beta Channel)
Development

Successfully merging this pull request may close these issues.
2 participants
@luixxiul @cezaraugusto