-
Notifications
You must be signed in to change notification settings - Fork 973
reliably activate titleMode based on mouse state #9411
Conversation
cd72869
to
d152013
Compare
@@ -750,8 +750,6 @@ class Frame extends React.Component { | |||
if (!this.frame.isEmpty()) { | |||
windowActions.setNavigated(e.url, this.props.frameKey, false, this.props.tabId) | |||
} | |||
// force temporary url display for tabnapping protection | |||
windowActions.setMouseInTitlebar(true) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tested both with and without this forced display and as far as I can tell no visual changes between them. In both cases, setting page to auto-refresh removes titleMode temporarily and letting tab idle while navigating other tab didn't make any action. Please let me know if I should test another scenario for tabnapping.
d152013
to
516afd1
Compare
btw I also confirmed with @bradleyrichter that titleMode should be always on when mouse is over navigation chrome and aways off when it is not. Currently, it is off when you move your mouse out of the window going all way top. This is not expected and was removed in this PR. |
@cezaraugusto I think you mean the inverse. When the mouse is in the title/search bar area, titlemode should be OFF and URL search bar mode should be ON. When the mouse exits the URL bar area, titlemode should return to on. |
before I forget: we'll want to test this logic when an alert is open (because an alert forces title mode) |
@bsclifton ok I updated STR with that, seems working as expected |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
test plan works. LGTM.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes work great 😄
There is something I noticed which will need a follow up- I'll create an issue and share here
Submitter Checklist:
git rebase -i
to squash commits (if needed).Auditors: @bbondy, @bsclifton
fix #9410
Test Plan:
General manual test plan is to:
Check when mouse is over navigation content, titleMode should be active. Otherwise it should not.
Also shortcuts such as cmd/ctrl+L and f6 should activate urlbar even when mouse is not over navigation content.
Below specific steps for bugs found in different platforms.
on macOS
on Windows
alert active
alert()
Reviewer Checklist:
Tests