Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Fix url parsing bug #9501

Merged
merged 2 commits into from
Jun 15, 2017
Merged

Fix url parsing bug #9501

merged 2 commits into from
Jun 15, 2017

Conversation

diracdeltas
Copy link
Member

@diracdeltas diracdeltas commented Jun 15, 2017

fix #9500

test plan:

  1. merge or rebase this on top of 0.17.x. verify that https://longextendedsubdomainnamewithoutdashesinordertotestwordwrapping.badssl.com/ shows the true URL origin in titleMode.

Submitter Checklist:

  • Submitted a ticket for my issue if one did not already exist.
  • Used Github auto-closing keywords in the commit message.
  • Added/updated tests for this change (for new code or code which already has tests).
  • Ran git rebase -i to squash commits (if needed).
  • Tagged reviewers and labelled the pull request as needed.

Test Plan:

Reviewer Checklist:

Tests

  • Adequate test coverage exists to prevent regressions
  • Tests should be independent and work correctly when run individually or as a suite ref
  • New files have MPL2 license header

@diracdeltas diracdeltas added this to the 0.17.x (Beta Channel) milestone Jun 15, 2017
@diracdeltas diracdeltas self-assigned this Jun 15, 2017
@diracdeltas diracdeltas requested review from ayumi and bbondy June 15, 2017 20:34
@ayumi
Copy link
Contributor

ayumi commented Jun 15, 2017

@ayumi
Copy link
Contributor

ayumi commented Jun 15, 2017

URL bar performance seems unchanged by this which is good

@diracdeltas
Copy link
Member Author

@ayumi good catch, i also just reverted 065b51a. not sure how to test it

@ayumi
Copy link
Contributor

ayumi commented Jun 15, 2017

@diracdeltas npm run test -- --grep="^urlBarSuggestions" is good for testing suggestions

@bsclifton bsclifton merged commit 91c8074 into master Jun 15, 2017
@bsclifton bsclifton deleted the fix/urlparse branch June 15, 2017 22:22
bsclifton added a commit that referenced this pull request Jun 15, 2017
bsclifton added a commit that referenced this pull request Jun 15, 2017
@luixxiul
Copy link
Contributor

Reverted with d142b24

@diracdeltas
Copy link
Member Author

@luixxiul the original bug wasn't reverted since it's fixed in d329334

@bsclifton
Copy link
Member

that is correct! @luixxiul, only part of the change was reverted (the commit, you mentioned, d142b24). The rest was legit 😄

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

incorrect hostname shown in titlemode when host is very long
6 participants