-
Notifications
You must be signed in to change notification settings - Fork 973
Fixes context menu not working on tabsbar #9525
Conversation
Resolves brave#9524 Auditors: @bsclifton Test Plan: - right click on tabs toolbar (on empty space) - context menu should open
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This works good on macOS, but doesn't work on Windows. Because of the style attributes required for dragging, the context menu doesn't auto-show
You may want to take a look at #8320, which solves this problem (and also adds a more usable menu). It ended up being reverted because of hitbox issues which may be solved now
This issue is not solving any specific problems as you fond on windows. This PR only fixes a regression where we are passing wrong params into the function. We can track issue for this problem in #8320. |
@NejcZdovc gotcha- works for me 😄 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
++
Fixes context menu not working on tabsbar
Fixes context menu not working on tabsbar
I see the bookmarks toolbar context menu show up in a specific place (right on the edge of the tabs bar and tabset) when I right click on the empty space. Other places it bring up the browser context menu. @NejcZdovc @bsclifton Is this expected ? |
@srirambv context menu in bookmarks toolbar is not working for windows. More info here #4244 (comment). This PR only fixes macOS bug. |
@srirambv what @NejcZdovc said 😄 #4244 will need to be solved in order to have draggable areas that don't return the Windows system menu (ex: same menu that shows when you right click on a titlebar) |
Submitter Checklist:
git rebase -i
to squash commits (if needed).Resolves #9524
Auditors: @bsclifton
Test Plan:
Reviewer Checklist:
Tests