Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Moves bookmark item width into the state #9611

Closed
wants to merge 1 commit into from

Conversation

NejcZdovc
Copy link
Contributor

@NejcZdovc NejcZdovc commented Jun 20, 2017

Submitter Checklist:

  • Submitted a ticket for my issue if one did not already exist.
  • Used Github auto-closing keywords in the commit message.
  • Added/updated tests for this change (for new code or code which already has tests).
  • Ran git rebase -i to squash commits (if needed).
  • Tagged reviewers and labelled the pull request as needed.

Resolves #9517

Auditors: @bsclifton @bridiver @ayumi

Test Plan:

Reviewer Checklist:

Tests

  • Adequate test coverage exists to prevent regressions
  • Tests should be independent and work correctly when run individually or as a suite ref
  • New files have MPL2 license header

@NejcZdovc NejcZdovc added this to the 0.19.x (Nightly Channel) milestone Jun 20, 2017
@NejcZdovc NejcZdovc self-assigned this Jun 20, 2017
@NejcZdovc
Copy link
Contributor Author

NejcZdovc commented Jun 20, 2017

TODO

  • add updater, so that update from x to 0.19 will automatically update state
  • recalculate all bookmarks when you switch bookmarks toolbar display setting
  • calculate when importing bookmarks
  • calculate when syncing

@NejcZdovc NejcZdovc force-pushed the refactor/#9517-bookmark branch from a4c5416 to be4498e Compare June 26, 2017 09:43
@NejcZdovc NejcZdovc mentioned this pull request Jun 26, 2017
51 tasks
@NejcZdovc NejcZdovc removed this from the 0.19.x (Nightly Channel) milestone Jun 28, 2017
@NejcZdovc
Copy link
Contributor Author

closing for now, because we need to find another way to calculate font length

@NejcZdovc NejcZdovc closed this Jul 5, 2017
NejcZdovc added a commit to NejcZdovc/browser-laptop that referenced this pull request Aug 7, 2017
NejcZdovc added a commit to NejcZdovc/browser-laptop that referenced this pull request Aug 7, 2017
bbondy added a commit that referenced this pull request Sep 26, 2017
Moves bookmark text calculation into the state
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants