This repository has been archived by the owner on Dec 11, 2019. It is now read-only.
Command+L when in url bar with URL bar suggestion should select full URL #9928
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was also a lot of other fixes which moves things out of the
component and into the store.
Note that there are no state functions in use yet for the window
renderer so I didn't create them yet as part of this task and just
used immutableJS directly.
I also fixed some intermittents with this fix.
Fix #9914
Auditors: @bsclifton
Test Plan:
command+L and make sure it selects all text.
Automated test plan
npm run test -- --grep="selects full url when autocompleting with partial selection"
Submitter Checklist:
git rebase -i
to squash commits (if needed).Reviewer Checklist:
Tests