Skip to content

Commit

Permalink
[LCPP] Make LCPP web_tests exclusive to VirtualTests
Browse files Browse the repository at this point in the history
Based on the feedback on crrev.com/c/4767918, this CL switches
LCPP web_tests to be exclusively virtual and drops
the TestExpectations.

Bug: 1419756
Change-Id: Ib5acfd90b68d136ee526edfa8d419988b7d5e405
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4792062
Reviewed-by: Weizhong Xia <weizhong@google.com>
Reviewed-by: Kouhei Ueno <kouhei@chromium.org>
Commit-Queue: Kouhei Ueno <kouhei@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1187421}
  • Loading branch information
Alex N. Jose authored and Chromium LUCI CQ committed Aug 23, 2023
1 parent 8e8d190 commit 030e44f
Show file tree
Hide file tree
Showing 2 changed files with 1 addition and 3 deletions.
3 changes: 0 additions & 3 deletions third_party/blink/web_tests/TestExpectations
Original file line number Diff line number Diff line change
Expand Up @@ -6656,9 +6656,6 @@ crbug.com/626703 virtual/css-highlight-overlay-painting/external/wpt/css/css-hig
# Gardening 2023-07-06
crbug.com/1462500 [ Win ] media/picture-in-picture/picture-in-picture-interstitial-sizing.html [ Failure Pass ]

# Until LCPP is unflagged, LCPP tests run in virtual tests.
crbug.com/1419756 http/tests/lcp_critical_path_predictor/* [ Crash Failure ]

# Accessibility causes unrelated rendering change
crbug.com/1470474 fast/ruby/ruby-position-modern-japanese-fonts.html [ Failure Pass ]

Expand Down
1 change: 1 addition & 0 deletions third_party/blink/web_tests/VirtualTestSuites
Original file line number Diff line number Diff line change
Expand Up @@ -2423,6 +2423,7 @@
"bases": [
"http/tests/lcp_critical_path_predictor"
],
"exclusive_tests": "ALL",
"args": [
"--enable-features=LCPCriticalPathPredictor",
"--disable-threaded-compositing", "--disable-threaded-animation"
Expand Down

0 comments on commit 030e44f

Please sign in to comment.