forked from chromium/chromium
-
Notifications
You must be signed in to change notification settings - Fork 17
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
[APS] Add tooltip text and circular highlight for StatusView
Demo: https://drive.google.com/file/d/19ZWK0emmShyTWOjdl52mvHrtz-6U1zxT/view?usp=sharing Additional demo to verify long-click: https://drive.google.com/file/d/1AVdyEHtcRnJkVkexk8fjgN7Rmb6dklAF/view?usp=sharing Bug: 1473109 Change-Id: Icd9c1d252c80a1b05ef040547923e26129d546d7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4799113 Reviewed-by: Aishwarya Rajesh <aishwaryarj@google.com> Reviewed-by: Theresa Sullivan <twellington@chromium.org> Code-Coverage: findit-for-me@appspot.gserviceaccount.com <findit-for-me@appspot.gserviceaccount.com> Commit-Queue: Zhe Li <zheliooo@google.com> Reviewed-by: Sirisha Kavuluru <skavuluru@google.com> Cr-Commit-Position: refs/heads/main@{#1188104}
- Loading branch information
Zhe Li
authored and
Chromium LUCI CQ
committed
Aug 25, 2023
1 parent
cf2f5f6
commit bc4d3e8
Showing
6 changed files
with
47 additions
and
1 deletion.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
19 changes: 19 additions & 0 deletions
19
chrome/browser/ui/android/omnibox/java/res/drawable/status_view_highlight_layer_list.xml
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,19 @@ | ||
<?xml version="1.0" encoding="utf-8"?> | ||
<!-- | ||
Copyright 2023 The Chromium Authors | ||
Use of this source code is governed by a BSD-style license that can be | ||
found in the LICENSE file. | ||
--> | ||
|
||
<layer-list xmlns:android="http://schemas.android.com/apk/res/android"> | ||
<!-- Background for the hovered and pressed state --> | ||
<item | ||
android:width="@dimen/status_view_highlight_size" | ||
android:height="@dimen/status_view_highlight_size" | ||
android:gravity="center"> | ||
|
||
<shape android:shape="oval"> | ||
<solid android:color="@color/toolbar_button_highlight_color" /> | ||
</shape> | ||
</item> | ||
</layer-list> |
14 changes: 14 additions & 0 deletions
14
chrome/browser/ui/android/omnibox/java/res/drawable/status_view_ripple.xml
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,14 @@ | ||
<?xml version="1.0" encoding="utf-8"?> | ||
<!-- | ||
Copyright 2023 The Chromium Authors | ||
Use of this source code is governed by a BSD-style license that can be | ||
found in the LICENSE file. | ||
--> | ||
|
||
<ripple xmlns:android="http://schemas.android.com/apk/res/android" | ||
android:color="?android:attr/colorControlHighlight"> | ||
<item | ||
android:id="@android:id/content" | ||
android:drawable="@drawable/status_view_highlight_layer_list"> | ||
</item> | ||
</ripple> |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters