Skip to content

Merge pull request #43 from brave/speedreader-0.8.4 #96

Merge pull request #43 from brave/speedreader-0.8.4

Merge pull request #43 from brave/speedreader-0.8.4 #96

Triggered via push January 31, 2024 21:28
Status Success
Total duration 27s
Artifacts

lint.yaml

on: push
Fit to window
Zoom out
Zoom in

Annotations

12 warnings
this returns a `Result<_, ()>`: src/select.rs#L351
warning: this returns a `Result<_, ()>` --> src/select.rs:351:5 | 351 | pub fn compile(s: &str) -> Result<Selectors, ()> { | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = help: use a custom `Error` type instead = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#result_unit_err
this returns a `Result<_, ()>`: src/select.rs#L351
warning: this returns a `Result<_, ()>` --> src/select.rs:351:5 | 351 | pub fn compile(s: &str) -> Result<Selectors, ()> { | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = help: use a custom `Error` type instead = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#result_unit_err
this returns a `Result<_, ()>`: src/iter.rs#L455
warning: this returns a `Result<_, ()>` --> src/iter.rs:455:5 | 455 | fn select(self, selectors: &str) -> Result<Select<Self>, ()> { | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = help: use a custom `Error` type instead = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#result_unit_err
this returns a `Result<_, ()>`: src/iter.rs#L446
warning: this returns a `Result<_, ()>` --> src/iter.rs:446:5 | 446 | fn select(self, selectors: &str) -> Result<Select<Elements<Self>>, ()> { | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = help: use a custom `Error` type instead = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#result_unit_err
this returns a `Result<_, ()>`: src/iter.rs#L455
warning: this returns a `Result<_, ()>` --> src/iter.rs:455:5 | 455 | fn select(self, selectors: &str) -> Result<Select<Self>, ()> { | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = help: use a custom `Error` type instead = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#result_unit_err
this returns a `Result<_, ()>`: src/iter.rs#L446
warning: this returns a `Result<_, ()>` --> src/iter.rs:446:5 | 446 | fn select(self, selectors: &str) -> Result<Select<Elements<Self>>, ()> { | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = help: use a custom `Error` type instead = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#result_unit_err
this returns a `Result<_, ()>`: src/iter.rs#L165
warning: this returns a `Result<_, ()>` --> src/iter.rs:165:5 | 165 | pub fn select_first(&self, selectors: &str) -> Result<NodeDataRef<ElementData>, ()> { | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = help: use a custom `Error` type instead = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#result_unit_err
this returns a `Result<_, ()>`: src/iter.rs#L159
warning: this returns a `Result<_, ()>` --> src/iter.rs:159:5 | 159 | pub fn select(&self, selectors: &str) -> Result<Select<Elements<Descendants>>, ()> { | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = help: use a custom `Error` type instead = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#result_unit_err = note: `#[warn(clippy::result_unit_err)]` on by default
this returns a `Result<_, ()>`: src/iter.rs#L165
warning: this returns a `Result<_, ()>` --> src/iter.rs:165:5 | 165 | pub fn select_first(&self, selectors: &str) -> Result<NodeDataRef<ElementData>, ()> { | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = help: use a custom `Error` type instead = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#result_unit_err
this returns a `Result<_, ()>`: src/iter.rs#L159
warning: this returns a `Result<_, ()>` --> src/iter.rs:159:5 | 159 | pub fn select(&self, selectors: &str) -> Result<Select<Elements<Descendants>>, ()> { | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = help: use a custom `Error` type instead = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#result_unit_err = note: `#[warn(clippy::result_unit_err)]` on by default
lint
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/checkout@v3, actions-rs/clippy-check@v1. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
lint
The following actions uses node12 which is deprecated and will be forced to run on node16: actions-rs/clippy-check@v1. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/