Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): update actions/checkout action to v4.1.3 #48

Merged
merged 1 commit into from
Apr 24, 2024

Conversation

renovate[bot]
Copy link
Contributor

@renovate renovate bot commented Apr 24, 2024

Mend Renovate

This PR contains the following updates:

Package Type Update Change
actions/checkout action patch v4.1.1 -> v4.1.3

Release Notes

actions/checkout (actions/checkout)

v4.1.3

Compare Source

What's Changed

Full Changelog: actions/checkout@v4.1.2...v4.1.3

v4.1.2

Compare Source


Configuration

📅 Schedule: Branch creation - "* 0-4 * * 3" (UTC), Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.


  • If you want to rebase/retry this PR, check this box

This PR has been generated by Mend Renovate. View repository job log here.

@renovate renovate bot requested a review from a team as a code owner April 24, 2024 01:06
Copy link

[puLL-Merge] - actions/checkout@v4.1.1..v4.1.3

Description

This PR makes several changes to the actions/checkout codebase, including:

  • Adding support to disable sparse checkout when the sparse-checkout input is not present
  • Adding a new ssh-user input to specify the SSH user to login as
  • Bumping the minimum required Git version for sparse checkout from 2.25 to 2.28
  • Adding a new test-ubuntu-git Docker image for testing actions/checkout in CI/CD
  • Updating the README and CHANGELOG
  • Bumping the package version to 4.1.3

The main motivation seems to be to improve support for sparse checkout and add more configurability around SSH.

Changes

Changes

  • .github/workflows/test.yml - Adds tests for disabling sparse checkout and updates the test container image to test-ubuntu-git
  • .github/workflows/update-main-version.yml - Pins actions/checkout to a specific version in the update workflow
  • .github/workflows/update-test-ubuntu-git.yml - New workflow to publish the test-ubuntu-git container image
  • CHANGELOG.md - Adds entries for v4.1.1 and v4.1.2 changes
  • README.md - Documents the new ssh-user input
  • __test__/git-version.test.ts - Adds tests for the new minimum Git version required for sparse checkout
  • action.yml - Defines the new ssh-user input
  • src/git-command-manager.ts - Implements disabling sparse checkout, bumps min version to 2.28
  • src/git-source-provider.ts - Disables sparse checkout if not configured
  • src/git-source-settings.ts, src/input-helper.ts - Handles the new ssh-user input
  • src/url-helper.ts - Uses ssh-user when building SSH URLs
  • images/ - Adds Dockerfile and docs for new test-ubuntu-git image
  • package.json - Bumps version to 4.1.3

Security Hotspots

  1. The new ssh-user input could allow specifying an arbitrary user for SSH authentication. This input should be validated to prevent command injection. The risk is relatively low since this just changes the remote URL.

  2. The test-ubuntu-git image is rebuilt without pinning specific versions of Ubuntu and Git. To prevent introducing vulnerabilities over time, consider pinning these versions explicitly in the Dockerfile. However, since this image is only used for testing, the risk is low.

  3. Bumping the minimum Git version could break existing workflows relying on older Git versions with sparse checkout enabled. The fix is to disable sparse checkout for older Git versions, which this PR implements. So the breaking change risk is mitigated.

Overall this PR looks good from a security perspective with no major risks. The improved sparse checkout support and SSH configurability are useful enhancements. Suggest moving forward after considering pinning versions in the test container image.

Copy link
Contributor

@rillian rillian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Keep ci scripts up to date

@rillian rillian merged commit 7d537b5 into main Apr 24, 2024
5 checks passed
@rillian rillian deleted the renovate/actions-checkout-4.x branch April 24, 2024 20:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant