This repository has been archived by the owner on Oct 12, 2023. It is now read-only.
Add support for component updater #4
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Could we pull out an |
|
yes good idea, I'll do that tomorrow. |
bridiver
reviewed
Sep 20, 2016
| @@ -60,41 +60,57 @@ BINARIES = { | |||
| 'darwin': [ | |||
| 'chromedriver', | |||
| 'mksnapshot', | |||
| 'libupdate_client.a', | |||
There was a problem hiding this comment.
can you also move the dist files to an update_client.py file?
Merged
bbondy
force-pushed
the
component_updater53
branch
2 times, most recently
from
3a630dd to
62fcb4b
Compare
bbondy
force-pushed
the
component_updater53
branch
from
62fcb4b to
711dc5f
Compare
|
not sure why this didn't auto-close, but merged manually |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Auditors: @bridiver @darkdh