Skip to content
This repository has been archived by the owner on Jan 4, 2019. It is now read-only.

Commit

Permalink
fix duplicate symbols on windows
Browse files Browse the repository at this point in the history
  • Loading branch information
bridiver committed Dec 15, 2016
1 parent 0b00434 commit 91d74aa
Show file tree
Hide file tree
Showing 2 changed files with 1 addition and 2 deletions.
1 change: 0 additions & 1 deletion build/node/BUILD.gn
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,6 @@ source_set("node") {
public_deps = [
":build_node",
"//v8:v8",
"//third_party/boringssl:boringssl",
]
}

Expand Down
2 changes: 1 addition & 1 deletion build/node/node.gypi
Original file line number Diff line number Diff line change
Expand Up @@ -201,7 +201,7 @@
}],
],
}],
['_target_name=="boringssl"', {
['_target_name=="openssl"', {
'xcode_settings': {
'DEAD_CODE_STRIPPING': 'YES', # -Wl,-dead_strip
'GCC_INLINES_ARE_PRIVATE_EXTERN': 'YES',
Expand Down

2 comments on commit 91d74aa

@darkdh
Copy link
Member

@darkdh darkdh commented on 91d74aa Dec 15, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

++

@bsclifton
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

++

Please sign in to comment.