Add webview event for security state changes

Needed to address brave/browser-laptop#5490 and brave/browser-laptop#5238 Auditors: @bsclifton @bbondy
brave · Nov 9, 2016 · ca0aefe · bridiver · Nov 9, 2016 · ca0aefe
1 parent 6227151
commit ca0aefe
Show file tree

Hide file tree

Showing 4 changed files with 25 additions and 0 deletions.
diff --git a/atom/browser/api/atom_api_web_contents.cc b/atom/browser/api/atom_api_web_contents.cc
@@ -890,6 +890,26 @@ void WebContents::DidFinishNavigation(
   }
 }
 
+void WebContents::SecurityStyleChanged(
+    content::SecurityStyle security_style,
+    const content::SecurityStyleExplanations& explanations) {
+    std::string type = "unknown";
+    switch (security_style) {
+      case content::SECURITY_STYLE_UNAUTHENTICATED:
+      case content::SECURITY_STYLE_AUTHENTICATION_BROKEN:
+        type = "insecure";
+        break;
+      case content::SECURITY_STYLE_WARNING:
+        type = "warning";
+        break;
+      case content::SECURITY_STYLE_AUTHENTICATED:
+        type = "secure";
+        break;
+      default: break;
+    }
+    Emit("did-change-security", type);
+}
+
 void WebContents::TitleWasSet(content::NavigationEntry* entry,
                               bool explicit_set) {
   if (entry)

diff --git a/atom/browser/api/atom_api_web_contents.h b/atom/browser/api/atom_api_web_contents.h
@@ -372,6 +372,9 @@ class WebContents : public mate::TrackableObject<WebContents>,
   void WebContentsDestroyed() override;
   void NavigationEntryCommitted(
       const content::LoadCommittedDetails& load_details) override;
+  void SecurityStyleChanged(
+      content::SecurityStyle security_style,
+      const content::SecurityStyleExplanations& explanations) override;
   void TitleWasSet(content::NavigationEntry* entry, bool explicit_set) override;
   void DidUpdateFaviconURL(
       const std::vector<content::FaviconURL>& urls) override;

diff --git a/lib/browser/guest-view-manager.js b/lib/browser/guest-view-manager.js
@@ -33,6 +33,7 @@ let supportedWebViewEvents = [
   'will-navigate',
   'did-navigate',
   'did-navigate-in-page',
+  'did-change-security',
   'close',
   'crashed',
   'gpu-crashed',

diff --git a/lib/renderer/web-view/guest-view-internal.js b/lib/renderer/web-view/guest-view-internal.js
@@ -35,6 +35,7 @@ var WEB_VIEW_EVENTS = {
   'gpu-crashed': [],
   'plugin-crashed': ['name', 'version'],
   'destroyed': [],
+  'did-change-security': ['securityState'],
   'page-title-updated': ['title', 'explicitSet'],
   'page-favicon-updated': ['favicons'],
   'enter-html-full-screen': [],